Help Clang find bottom of stacks for safety, use desired stack size#873
Open
dtzWill wants to merge 1 commit intoMaskRay:masterfrom
Open
Help Clang find bottom of stacks for safety, use desired stack size#873dtzWill wants to merge 1 commit intoMaskRay:masterfrom
dtzWill wants to merge 1 commit intoMaskRay:masterfrom
Conversation
noteBottomOfStack: Without this, checks against stack space within Clang don't work as Clang doesn't know where the stack begins. Needed per-thread, as early as possible. (on threads using Clang) Using Clang's desired stack size: Additionally increase stack size of pthreads to Clang's desired size. This is presently 8MB, and is used by Clang's stack management mechanisms to check* if close to stack exhaustion when determining if there's sufficient space (and warn or run on a new thread with more). (see runWithSufficientStackSpace) The constant is available in LLVM 7 onwards. * (abs(cur - bottom) > DesiredStackSize - threshold)
Author
This fixes crashes encountered pointing ccls at CIRCT (+llvm submodule), which was my motivation. I haven't looked into making that reproducible (on other systems), so not sure if that's specific to my setup. Stack was very deep (just shy of 10k frames) and included many calls to |
MaskRay
force-pushed
the
master
branch
3 times, most recently
from
db890d4 to
cc13ced
Compare
MaskRay
force-pushed
the
master
branch
3 times, most recently
from
e403622 to
cfc7c02
Compare
MaskRay
force-pushed
the
master
branch
2 times, most recently
from
49cbf37 to
aca8280
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noteBottomOfStack:
Without this, checks against stack space within Clang don't work as
Clang doesn't know where the stack begins.
Needed per-thread, as early as possible.
(on threads using Clang)
Using Clang's desired stack size:
Additionally increase stack size of pthreads to Clang's desired size.
This is presently 8MB, and is used by Clang's stack management
mechanisms to check* if close to stack exhaustion when determining if
there's sufficient space (and warn or run on a new thread with more).
(see runWithSufficientStackSpace)
The constant is available in LLVM 7 onwards.